PySMO: fix warnings #1472
Merged
PySMO: fix warnings #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
- Coverage 76.36% 76.36% -0.01%
==========================================
Files 394 394
Lines 65130 65136 +6
Branches 14429 14429
==========================================
+ Hits 49737 49740 +3
- Misses 12831 12835 +4
+ Partials 2562 2561 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Thanks a lot @OOAmusat. From a quick look through the pytest job output log, I believe this resolves all of the unanticipated warnings from the PySMO submodules (i.e., I wasn't able to spot any).
The only one that looks like it might be related is the following:
However, if you feel this belongs outside of PySMO's "jurisdiction", then feel free to disregard and we can address it at a later time.
andrewlee94
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1403, #1363
Summary/Motivation:
Recent changes to the numpy backend have resulted in a large number of deprecation warnings (>7500) being raised in PySMO. This PR makes changes to address these warnings.
Changes proposed in this PR:
y[i, 0] = x. This is resolved in this PR by either extracting the specific elements of the scalar (y[i, 0] = x[0]) or using the item method (y[i, 0] = x.item())warnings.warnwith the idaes logger warnings, and fix tests to usecaplogto reflect this change@pytest.mark.filterwarningsto specific tests to ignore runtime warnings aroundnp.logLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: